-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapping up interceptors, fixing typos, removing Moq #2141
Conversation
@fseidl-bauradar you might want to take a look |
Deploying restsharp with Cloudflare Pages
|
I am not sure if throwing in interceptors should crash the request, like it's expected in tests. The current OnXXX hooks can produce exceptions, and if that results in client throwing depends on throw options. I want to replace the current hooks with interceptors, so I think they should express the same behaviour. |
In my project, I am currently using it to convert a ErrorDTO from the DTO into a Exception. |
Yeah, I didn't think that interceptors can't cancel the request, but the way it work now with hooks is that the |
Sorry, but your answer is a little bit confusing, Am I understanding you right? |
Have you found the reason for the build errors on linux and Claudflare Pages? |
# Conflicts: # src/Directory.Build.props # src/RestSharp/RestClient.cs
- Added docs - Refactored tests for the hooks - Updated packages
OnBeforeDerialization
to the right place